Conversation
Collaborator
|
Can you add context for why you are making this change to the PR? Is this a user request or just for parity? |
Contributor
Author
|
Updated - basically just for parity. |
solbrigm
approved these changes
Jul 24, 2025
Contributor
Author
Merge activity
|
zack13532
deleted the
07-23-make_all_options_optional_and_update_requestoptions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://github.com/tecton-ai/tecton/pull/31995 added a new request option that users can set when making calls to the Feature Server HTTP API, and we should port this (and other options that have been added) to our clients as well.
Additionally decided to make the attributes of
MetadataOptionsandRequestOptionsoptional values to better reflect the HTTP API, and to fallback to the default values defined by the service.MetadataOptionsandRequestOptionsclass to useOptionalwithNoneas default values instead of hardcoded boolean defaultsMetadataOptions.all()as-isto_request()method in each to only include parameters that are explicitly setRequestOptionsclass with three new parameters:ignore_extra_request_context_fieldslatency_budget_mscoerce_null_counts_to_zeroLinear
ref RT-2159